[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/13] hw/smbios: add stub for smbios_get_table_legacy()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 10/13] hw/smbios: add stub for smbios_get_table_legacy() |
Date: |
Tue, 26 Mar 2024 16:45:01 +0100 |
From: Igor Mammedov <imammedo@redhat.com>
QEMU build fails with
hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy'
when it's built with only 'microvm' enabled i.e. with config patch
+++ b/configs/devices/i386-softmmu/default.mak
@@ -26,7 +26,7 @@
# Boards:
#
-CONFIG_ISAPC=y
-CONFIG_I440FX=y
-CONFIG_Q35=y
+CONFIG_ISAPC=n
+CONFIG_I440FX=n
+CONFIG_Q35=n
It happens because I've fogotten/lost smbios_get_table_legacy() stub.
Fix it by adding missing stub as Philippe suggested.
Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine"
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20240326122630.85989-1-imammedo@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/smbios/smbios_legacy_stub.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/smbios/smbios_legacy_stub.c b/hw/smbios/smbios_legacy_stub.c
index f29b15316c..7d593dca98 100644
--- a/hw/smbios/smbios_legacy_stub.c
+++ b/hw/smbios/smbios_legacy_stub.c
@@ -13,3 +13,8 @@
void smbios_add_usr_blob_size(size_t size)
{
}
+
+uint8_t *smbios_get_table_legacy(size_t *length, Error **errp)
+{
+ g_assert_not_reached();
+}
--
2.41.0
- [PULL 00/13] Misc HW patches for 2024-03-26, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 02/13] hw/scsi/scsi-generic: Fix io_timeout property not applying, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 01/13] target/i386/tcg: Enable page walking from MMIO memory, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 03/13] monitor/hmp-cmds-target: Append a space in error message in gpa2hva(), Philippe Mathieu-Daudé, 2024/03/26
- [PULL 04/13] target/tricore/helper: Use correct string format in cpu_tlb_fill(), Philippe Mathieu-Daudé, 2024/03/26
- [PULL 05/13] hw/clock: Let clock_set_mul_div() return a boolean value, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 06/13] hw/misc/stm32l4x5_rcc: Inline clock_update() in clock_mux_update(), Philippe Mathieu-Daudé, 2024/03/26
- [PULL 07/13] hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 09/13] contrib/plugins/execlog: Fix compiler warning, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 08/13] docs/system/ppc/amigang.rst: Fix formatting, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 10/13] hw/smbios: add stub for smbios_get_table_legacy(),
Philippe Mathieu-Daudé <=
- [PULL 11/13] ui/cocoa: Fix aspect ratio, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 12/13] ui/cocoa: Resize window after toggling zoom-to-fit, Philippe Mathieu-Daudé, 2024/03/26
- [PULL 13/13] ui/cocoa: Use NSTrackingInVisibleRect, Philippe Mathieu-Daudé, 2024/03/26
- Re: [PULL 00/13] Misc HW patches for 2024-03-26, Peter Maydell, 2024/03/26