Re: [PATCH trivial for-9.0] smbios: add stub for smbios_get_table_legacy()

[Philippe Mathieu-Daudé]

On 26/3/24 13:26, Igor Mammedov wrote:
> QEMU build fails with
>    hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy'
> when it's built with only 'microvm' enabled i.e. with config patch
>     +++ b/configs/devices/i386-softmmu/default.mak
>     @@ -26,7 +26,7 @@
>
>     # Boards:
>     #
>     -CONFIG_ISAPC=y
>     -CONFIG_I440FX=y
>     -CONFIG_Q35=y
>     +CONFIG_ISAPC=n
>     +CONFIG_I440FX=n
>     +CONFIG_Q35=n
>
> it happens because I've fogotten/lost smbios_get_table_legacy() stub.
>
> Fix it by adding missing stub as Philippe suggested.
>
> Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine"
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Singned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> Compile tested only.
>
> While it's fixing bug for off-tree usecase with non-upstream config,
> it's trivial enough to go into 9.0 if time frame allows.
> Benefit of it going into 9.0 is that folks who play with minimal builds
> won't have to carry the patch in their tree.
>
>
>   hw/smbios/smbios_legacy_stub.c | 5 +++++
>   1 file changed, 5 insertions(+)

Thanks, patch queued.