qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] scsi-generic: fix io_timeout property not applying


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] scsi-generic: fix io_timeout property not applying
Date: Tue, 26 Mar 2024 11:00:06 +0100
User-agent: Mozilla Thunderbird

On 15/3/24 15:58, Lorenz Brun wrote:
The io_timeout property, introduced in c9b6609 (part of 6.0) is
silently overwritten by the hardcoded default value of 30 seconds
(DEFAULT_IO_TIMEOUT) in scsi_generic_realize because that function is
being called after the properties have already been applied.

The property definition already has a default value which is applied
correctly when no value is explicitly set, so we can just remove the
code which overrides the io_timeout completely.

This has been tested by stracing SG_IO operations with the io_timeout
property set and unset and now sets the timeout field in the ioctl
request to the proper value.

Fixes: c9b6609b69facad ("scsi: make io_timeout configurable")
Signed-off-by: Lorenz Brun <lorenz@brun.one>
---
  hw/scsi/scsi-generic.c | 1 -
  1 file changed, 1 deletion(-)

Thanks, patch queued.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]