Re: [PATCH] qapi: document leftover members in qapi/stats.json

[Markus Armbruster]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qapi/stats.json | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/qapi/stats.json b/qapi/stats.json
> index ce9d8161ecb..578b52c7ef7 100644
> --- a/qapi/stats.json
> +++ b/qapi/stats.json
> @@ -114,13 +114,13 @@
>  #
>  # The arguments to the query-stats command; specifies a target for
>  # which to request statistics and optionally the required subset of
> -# information for that target:
> +# information for that target.
>  #
> -# - which vCPUs to request statistics for
> -# - which providers to request statistics from
> -# - which named values to return within each provider
> +# @target: the kind of objects to query.  Note that each possible
> +#          target may enable additional filtering options
>  #
> -# @target: the kind of objects to query
> +# @providers: which providers to request statistics from, and optionally
> +#             which named values to return within each provider
>  #
>  # Since: 7.1
>  ##
> @@ -136,6 +136,8 @@
>  #
>  # @scalar: single unsigned 64-bit integers.
>  #
> +# @boolean: single boolean value.
> +#
>  # @list: list of unsigned 64-bit integers (used for histograms).
>  #
>  # Since: 7.1
> @@ -254,6 +256,8 @@
>  #
>  # Return the schema for all available runtime-collected statistics.
>  #
> +# @provider: a provider to restrict the query to.
> +#
>  # Note: runtime-collected statistics and their names fall outside
>  #     QEMU's usual deprecation policies.  QEMU will try to keep the
>  #     set of available data stable, together with their names, but

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Queued, thanks!