Re: [PATCH v3 01/17] esp.c: move esp_fifo_pop_buf() internals to new esp_fifo8_pop_buf() function

[Philippe Mathieu-Daudé]

On 24/3/24 20:16, Mark Cave-Ayland wrote:
> Update esp_fifo_pop_buf() to be a simple wrapper onto the new 
> esp_fifo8_pop_buf()
> function.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hw/scsi/esp.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)


> +static uint32_t esp_fifo_pop_buf(Fifo8 *fifo, uint8_t *dest, int maxlen)

If future cleanups, maxlen can be unsigned (size_t), anyhow:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +{
> +    return esp_fifo8_pop_buf(fifo, dest, maxlen);
> +}
> +
>   static uint32_t esp_get_tc(ESPState *s)
>   {
>       uint32_t dmalen;