qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.0 v2] vhost-vdpa: check vhost_vdpa_set_vring_ready() re


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-9.0 v2] vhost-vdpa: check vhost_vdpa_set_vring_ready() return value
Date: Fri, 22 Mar 2024 16:01:38 +0100
User-agent: Mozilla Thunderbird

On 22/3/24 10:23, Stefano Garzarella wrote:
vhost_vdpa_set_vring_ready() could already fail, but if Linux's
patch [1] will be merged, it may fail with more chance if
userspace does not activate virtqueues before DRIVER_OK when
VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is not negotiated.

So better check its return value anyway.

[1] 
https://lore.kernel.org/virtualization/20240206145154.118044-1-sgarzare@redhat.com/T/#u

Acked-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
Based-on: 20240315155949.86066-1-kwolf@redhat.com

v1: https://patchew.org/QEMU/20240207092702.25242-1-sgarzare@redhat.com/
v2:
  - added acks
  - rebased on top of 
20240315155949.86066-1-kwolf@redhat.com/">https://patchew.org/QEMU/20240315155949.86066-1-kwolf@redhat.com/
---
  net/vhost-vdpa.c | 15 ++++++++++++---
  1 file changed, 12 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]