[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] qapi: Fix bogus documentation of query-migrationthreads
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH 3/3] qapi: Fix bogus documentation of query-migrationthreads |
|
Date: |
Fri, 22 Mar 2024 11:11:58 -0300 |
Markus Armbruster <armbru@redhat.com> writes:
> The doc comment documents an argument that doesn't exist. Would
> fail compilation if it was marked up correctly. Delete.
>
> The Returns: section fails to refer to the data type, leaving the user
> to guess. Fix that.
>
> The command name violates QAPI naming rules: it should be
> query-migration-threads. Too late to fix.
>
> Reported-by: John Snow <jsnow@redhat.com>
> Fixes: 671326201dac (migration: Introduce interface query-migrationthreads)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>