Re: [PATCH v2 2/2] Refactor common functions between POSIX and Windows implementation

[Daniel P . Berrangé]

On Thu, Mar 21, 2024 at 04:07:25PM +0000, aidan_leuck@selinc.com wrote:
> From: aidaleuc <aidan_leuck@selinc.com>
> 
> Signed-off-by: aidaleuc <aidan_leuck@selinc.com>
> ---
>  qga/commands-posix-ssh.c   | 47 +--------------------------
>  qga/commands-ssh-core.c    | 57 ++++++++++++++++++++++++++++++++
>  qga/commands-ssh-core.h    |  8 +++++
>  qga/commands-windows-ssh.c | 66 +-------------------------------------
>  qga/meson.build            |  3 +-
>  5 files changed, 69 insertions(+), 112 deletions(-)
>  create mode 100644 qga/commands-ssh-core.c
>  create mode 100644 qga/commands-ssh-core.h

Moving of existing functions into a common file should
be the *first* patch in the series, rather than copying
functions into the windows impl only to immediately
remove them again.

> diff --git a/qga/commands-ssh-core.c b/qga/commands-ssh-core.c
> new file mode 100644
> index 0000000000..51353b396d
> --- /dev/null
> +++ b/qga/commands-ssh-core.c

> \ No newline at end of file

Again, please ensure all files retain a final newline in the file.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|