Re: [PATCH 1/3] target/hppa: add unit conditions for wide mode

[Richard Henderson]

On 3/21/24 10:10, Sven Schnelle wrote:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > On 3/21/24 08:42, Sven Schnelle wrote:
> > > Wide mode provides two more conditions, add them.
> > > Signed-off-by: Sven Schnelle <svens@stackframe.org>
> > > ---
> > >    target/hppa/translate.c | 25 +++++++++++++++++++++++--
> > >    1 file changed, 23 insertions(+), 2 deletions(-)
> > > diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> > > index 8a87996fc1..f493e207e1 100644
> > > --- a/target/hppa/translate.c
> > > +++ b/target/hppa/translate.c
> > > @@ -963,11 +963,22 @@ static DisasCond do_unit_cond(unsigned cf, bool d, 
> > > TCGv_i64 res,
> > >          switch (cf >> 1) {
> > >        case 0: /* never / TR */
> > > -    case 1: /* undefined */
> > > -    case 5: /* undefined */
> > >            cond = cond_make_f();
> > >            break;
> > >    +    case 1:
> >
> > Wants a comment for /* SWZ / NWZ */
> >
> > > +    case 5:
> >
> > /* SWC / NWC */
>
> Are you going to fix that up, or should i send a v2?

I'll fix it up.


r~