qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-9.0? 01/21] host/atomic128: Include missing 'qemu/atomic.


From: Richard Henderson
Subject: Re: [PATCH-for-9.0? 01/21] host/atomic128: Include missing 'qemu/atomic.h' header
Date: Thu, 21 Mar 2024 07:05:04 -1000
User-agent: Mozilla Thunderbird

On 3/21/24 05:48, Philippe Mathieu-Daudé wrote:
qatomic_cmpxchg__nocheck(), qatomic_read__nocheck(),
qatomic_set__nocheck() are defined in "qemu/atomic.h".
Include it in order to avoid:

   In file included from include/exec/helper-proto.h:10:
   In file included from include/exec/helper-proto-common.h:10:
   In file included from include/qemu/atomic128.h:61:
   In file included from host/include/aarch64/host/atomic128-cas.h:16:
   host/include/generic/host/atomic128-cas.h:23:11: error: call to undeclared 
function 'qatomic_cmpxchg__nocheck'; ISO C99 and later do not support implicit 
function declarations [-Wimplicit-function-declaration]
     r.i = qatomic_cmpxchg__nocheck(ptr_align, c.i, n.i);


Nak. We can rename these host/include/*/host/*atomic* as .h.inc if you need, but the top-level header is include/qemu/atomic128.h.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]