Re: [PATCH v3 11/49] physmem: Introduce ram_block_discard_guest_memfd_range()

[David Hildenbrand]

On 20.03.24 18:38, Michael Roth wrote:
> On Wed, Mar 20, 2024 at 10:37:14AM +0100, David Hildenbrand wrote:
> > On 20.03.24 09:39, Michael Roth wrote:
> > > From: Xiaoyao Li <xiaoyao.li@intel.com>
> > >
> > > When memory page is converted from private to shared, the original
> > > private memory is back'ed by guest_memfd. Introduce
> > > ram_block_discard_guest_memfd_range() for discarding memory in
> > > guest_memfd.
> > >
> > > Originally-from: Isaku Yamahata <isaku.yamahata@intel.com>
> > > Codeveloped-by: Xiaoyao Li <xiaoyao.li@intel.com>
> >
> > "Co-developed-by"
> >
> > > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> > > Reviewed-by: David Hildenbrand <david@redhat.com>
> >
> > Your SOB should go here.
> >
> > > ---
> > > Changes in v5:
> > > - Collect Reviewed-by from David;
> > >
> > > Changes in in v4:
> > > - Drop ram_block_convert_range() and open code its implementation in the
> > >     next Patch.
> > >
> > > Signed-off-by: Michael Roth <michael.roth@amd.com>
> >
> > I only received 3 patches from this series, and now I am confused: changelog
> > talks about v5 and this is "PATCH v3"
> >
> > Please make sure to send at least the cover letter along (I might not need
> > the other 46 patches :D ).
>
> Sorry for the confusion, you got auto-Cc'd by git, which is good, but
> not sure there's a good way to make sure everyone gets a copy of the
> cover letter. I could see how it would help useful to potential
> reviewers though. I'll try to come up with a script for it and take that
> approach in the future.

A script shared with me in the past to achieve that in most cases:

$ cat cc-cmd.sh
#!/bin/bash

if [[ $1 == *gitsendemail.msg* || $1 == *cover-letter* ]]; then
        grep ': .* <.*@.*>' -h *.patch | sed 's/^.*: //' | sort | uniq
fi


And attach to "git send-email ... *.patch": --cc-cmd=./cc-cmd.sh

--
Cheers,

David / dhildenb