[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines |
|
Date: |
Wed, 20 Mar 2024 11:53:14 -0300 |
Cédric Le Goater <clg@redhat.com> writes:
> Now that the log_global*() handlers take an Error** parameter and
> return a bool, do the same for memory_global_dirty_log_start() and
> memory_global_dirty_log_stop(). The error is reported in the callers
> for now and it will be propagated in the call stack in the next
> changes.
>
> To be noted a functional change in ram_init_bitmaps(), if the dirty
> pages logger fails to start, there is no need to synchronize the dirty
> pages bitmaps. colo_incoming_start_dirty_log() could be modified in a
> similar way.
>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Hyman Huang <yong.huang@smartx.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- Re: [PATCH for-9.1 v5 09/14] memory: Add Error** argument to .log_global_start() handler, (continued)
[PATCH for-9.1 v5 10/14] migration: Introduce ram_bitmaps_destroy(), Cédric Le Goater, 2024/03/20
[PATCH for-9.1 v5 12/14] migration: Add Error** argument to ram_state_init(), Cédric Le Goater, 2024/03/20
[PATCH for-9.1 v5 13/14] migration: Add Error** argument to xbzrle_init(), Cédric Le Goater, 2024/03/20
[PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines, Cédric Le Goater, 2024/03/20
[PATCH for-9.1 v5 14/14] migration: Modify ram_init_bitmaps() to report dirty tracking errors, Cédric Le Goater, 2024/03/20
Re: [PATCH for-9.1 v5 00/14] migration: Improve error reporting, Peter Xu, 2024/03/22