Re: [PATCH 0/9] Introduce support for IGVM files

[Roy Hopkins]

On Tue, 2024-03-19 at 16:07 +0100, Stefano Garzarella wrote:
> Hi Roy,
> thanks for this series!
> 
> On Tue, Feb 27, 2024 at 02:50:06PM +0000, Roy Hopkins wrote:
> > Hi everyone,
> > 
> > This initial patch series submission adds the capability to configure
> > confidential guests using files that conform to the Independent Guest
> > Virtual
> > Machine (IGVM) file format. The series is based on the master branch commit
> > 1b330da. Alternatively, the series is available here:
> > https://github.com/roy-hopkins/qemu/tree/igvm_master_v1
> > 
> > I look forward to welcoming your comments!
> 
> I saw that the series has been a posted for a while and maybe you're 
> going to send v2, so I'll bring back some little things that I saw, but 
> I didn't do yet a deep review:
> 
> - We use "Isolated Guest Virtual Machine" or "Independent Guest Virtual
>    Machine", are they interchangeable for IGVM?
> 
> - `./scripts/checkpatch.pl --codespell` reported some warnings:
> 
> 5/9 Checking commit 81f60e5cdd01 (i386/pc: Process IGVM file during PC
> initialization if present)
> WARNING: 'initalization' may be misspelled - perhaps 'initialization'?
> #15:
>      initalization of the target.
>      ^^^^^^^^^^^^^
> 
> 9/9 Checking commit 66745c0bb940 (docs/system: Add documentation on support
> for IGVM)
> 
> WARNING: 'encaspulate' may be misspelled - perhaps 'encapsulate'?
> #27: FILE: docs/system/igvm.rst:4:
> +IGVM files are designed to encaspulate all the information required to launch
> a
>                              ^^^^^^^^^^^
> 
> Thanks,
> Stefano
> 

Thanks for the initial review Stefano. I'll be posting a v2 shortly and will
address your comments.

Regards,
Roy

[snip]
>