[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] ui/vc: Do not inherit the size of active console
From: |
marcandre . lureau |
Subject: |
[PULL 1/5] ui/vc: Do not inherit the size of active console |
Date: |
Wed, 20 Mar 2024 17:53:45 +0400 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
A chardev-vc used to inherit the size of a graphic console when its
size not explicitly specified, but it often did not make sense. If a
chardev-vc is instantiated during the startup, the active graphic
console has no content at the time, so it will have the size of graphic
console placeholder, which contains no useful information. It's better
to have the standard size of text console instead.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20240319-console-v2-1-3fd6feef321a@daynix.com>
---
ui/console-vc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/console-vc.c b/ui/console-vc.c
index 9c13cc2981..f22c8e23c2 100644
--- a/ui/console-vc.c
+++ b/ui/console-vc.c
@@ -990,8 +990,8 @@ static void vc_chr_open(Chardev *chr,
trace_console_txt_new(width, height);
if (width == 0 || height == 0) {
s = QEMU_TEXT_CONSOLE(object_new(TYPE_QEMU_TEXT_CONSOLE));
- width = qemu_console_get_width(NULL, 80 * FONT_WIDTH);
- height = qemu_console_get_height(NULL, 24 * FONT_HEIGHT);
+ width = 80 * FONT_WIDTH;
+ height = 24 * FONT_HEIGHT;
} else {
s = QEMU_TEXT_CONSOLE(object_new(TYPE_QEMU_FIXED_TEXT_CONSOLE));
}
--
2.44.0
- [PULL 0/5] UI patches, marcandre . lureau, 2024/03/12
- [PULL 1/5] ui/vnc: Respect bound console, marcandre . lureau, 2024/03/12
- [PULL 2/5] ui/dbus: factor out sending a scanout, marcandre . lureau, 2024/03/12
- [PULL 5/5] virtio-gpu: fix scanout migration post-load, marcandre . lureau, 2024/03/12
- [PULL 4/5] virtio-gpu: remove needless condition, marcandre . lureau, 2024/03/12
- [PULL 3/5] ui/dbus: filter out pending messages when scanout, marcandre . lureau, 2024/03/12
- Re: [PULL 0/5] UI patches, Peter Maydell, 2024/03/12
- [PULL 0/5] Ui patches, marcandre . lureau, 2024/03/20
- [PULL 1/5] ui/vc: Do not inherit the size of active console,
marcandre . lureau <=
- [PULL 2/5] ui/vnc: Do not use console_select(), marcandre . lureau, 2024/03/20
- [PULL 3/5] ui/cocoa: Do not use console_select(), marcandre . lureau, 2024/03/20
- [PULL 4/5] ui/curses: Do not use console_select(), marcandre . lureau, 2024/03/20
- [PULL 5/5] ui: compile dbus-display1.c with -fPIC as necessary, marcandre . lureau, 2024/03/20
- Re: [PULL 0/5] Ui patches, Peter Maydell, 2024/03/20