Re: [PATCH] Revert mapped-ram multifd support to fd: URI

[Peter Xu]

On Tue, Mar 19, 2024 at 06:09:41PM -0300, Fabiano Rosas wrote:
> This reverts commit decdc76772c453ff1444612e910caa0d45cd8eac in full
> and also the relevant migration-tests from
> 7a09f092834641b7a793d50a3a261073bbb404a6.
> 
> After the addition of the new QAPI-based migration address API in 8.2
> we've been converting an "fd:" URI into a SocketAddress, missing the
> fact that the "fd:" syntax could also be used for a plain file instead
> of a socket. This is a problem because the SocketAddress is part of
> the API, so we're effectively asking users to create a "socket"
> channel to pass in a plain file.
> 
> The easiest way to fix this situation is to deprecate the usage of
> both SocketAddress and "fd:" when used with a plain file for
> migration. Since this has been possible since 8.2, we can wait until
> 9.1 to deprecate it.
> 
> For 9.0, however, we should avoid adding further support to migration
> to a plain file using the old "fd:" syntax or the new SocketAddress
> API, and instead require the usage of either the old-style "file:" URI
> or the FileMigrationArgs::filename field of the new API with the
> "/dev/fdset/NN" syntax, both of which are already supported.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

queued for 9.0-rc1.

-- 
Peter Xu