qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missi


From: Het Gala
Subject: Re: [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below
Date: Wed, 20 Mar 2024 02:22:11 +0530
User-agent: Mozilla Thunderbird

FYI: This 2 patches are rebased on top of another (tests/qtest/migration: Add tests for introducing 'channels' argument in migrate QAPIs) series. Can find the build for both the patches here: https://gitlab.com/galahet/Qemu/-/pipelines/1219841944

On 20/03/24 2:18 am, Het Gala wrote:
'object' can return NULL if there is no socket-address, such as with a
file migration. Then the visitor code below fails and the test crashes.

Ignore and return NULL when socket-address is missing in the reply so
we don't break future tests that use a non-socket type.

Suggested-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Het Gala <het.gala@nutanix.com>
---
  tests/qtest/migration-helpers.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index b2a90469fb..fb7156f09a 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest/migration-helpers.c
@@ -90,6 +90,10 @@ static SocketAddress *migrate_get_socket_address(QTestState 
*who)
      QObject *object;
rsp = migrate_query(who);
+
+    if (!qdict_haskey(rsp, "socket-address")) {
+        return NULL;
+    }
      object = qdict_get(rsp, "socket-address");
iv = qobject_input_visitor_new(object);
Regards,
Het Gala



reply via email to

[Prev in Thread] Current Thread [Next in Thread]