[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/8] crypto: query gcrypt for cipher availability
From: |
Daniel P . Berrangé |
Subject: |
[PULL 6/8] crypto: query gcrypt for cipher availability |
Date: |
Tue, 19 Mar 2024 20:21:19 +0000 |
Just because a cipher is defined in the gcrypt header file, does not
imply that it can be used. Distros can filter the list of ciphers when
building gcrypt. For example, RHEL-9 disables the SM4 cipher. It is
also possible that running in FIPS mode might dynamically change what
ciphers are available at runtime.
qcrypto_cipher_supports must therefore query gcrypt directly to check
for cipher availability.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
crypto/cipher-gcrypt.c.inc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/crypto/cipher-gcrypt.c.inc b/crypto/cipher-gcrypt.c.inc
index 6b82280f90..4a8314746d 100644
--- a/crypto/cipher-gcrypt.c.inc
+++ b/crypto/cipher-gcrypt.c.inc
@@ -93,6 +93,11 @@ bool qcrypto_cipher_supports(QCryptoCipherAlgorithm alg,
return false;
}
+ if (gcry_cipher_algo_info(qcrypto_cipher_alg_to_gcry_alg(alg),
+ GCRYCTL_TEST_ALGO, NULL, NULL) != 0) {
+ return false;
+ }
+
switch (mode) {
case QCRYPTO_CIPHER_MODE_ECB:
case QCRYPTO_CIPHER_MODE_CBC:
--
2.43.0
- [PULL 0/8] Misc fixes patches, Daniel P . Berrangé, 2024/03/19
- [PULL 2/8] chardev: lower priority of the HUP GSource in socket chardev, Daniel P . Berrangé, 2024/03/19
- [PULL 1/8] seccomp: report EPERM instead of killing process for spawn set, Daniel P . Berrangé, 2024/03/19
- [PULL 3/8] Revert "chardev/char-socket: Fix TLS io channels sending too much data to the backend", Daniel P . Berrangé, 2024/03/19
- [PULL 4/8] Revert "chardev: use a child source for qio input source", Daniel P . Berrangé, 2024/03/19
- [PULL 6/8] crypto: query gcrypt for cipher availability,
Daniel P . Berrangé <=
- [PULL 5/8] crypto: factor out conversion of QAPI to gcrypt constants, Daniel P . Berrangé, 2024/03/19
- [PULL 7/8] crypto: use error_abort for unexpected failures, Daniel P . Berrangé, 2024/03/19
- [PULL 8/8] crypto: report which ciphers are being skipped during tests, Daniel P . Berrangé, 2024/03/19
- Re: [PULL 0/8] Misc fixes patches, Peter Maydell, 2024/03/20