qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-9.1 5/8] target/microblaze: Restrict 64-bit 'res_addr' to


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-9.1 5/8] target/microblaze: Restrict 64-bit 'res_addr' to system emulation
Date: Tue, 19 Mar 2024 19:17:13 +0100
User-agent: Mozilla Thunderbird

On 19/3/24 17:27, Edgar E. Iglesias wrote:
On Tue, Mar 19, 2024 at 07:28:52AM +0100, Philippe Mathieu-Daudé wrote:
'res_addr' is only used in system emulation, where we have
TARGET_LONG_BITS = 64, so we can directly use the native
uint64_t type instead of target_ulong.


Hi Philippe,

This breaks linux-user, lwx and swx are valid user-mode insns.

Now I see I missed cpu_res_addr. Thanks for the quick review!


Best regards,
Edgar



Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  target/microblaze/cpu.h       | 10 +++++-----
  target/microblaze/cpu.c       |  2 ++
  target/microblaze/machine.c   |  2 +-
  target/microblaze/translate.c |  9 +++++++--
  4 files changed, 15 insertions(+), 8 deletions(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]