[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_co
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_command helper |
|
Date: |
Tue, 19 Mar 2024 17:58:37 +0000 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Fri, Mar 15, 2024 at 02:29:43PM +0200, Andrey Drobyshev wrote:
> There's no need to check for the existence of "/sbin/hwclock", the
> exec() call will do that for us.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> ---
> qga/commands-posix.c | 43 +++----------------------------------------
> 1 file changed, 3 insertions(+), 40 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 0/7] qga/commands-posix: replace code duplicating commands with a helper, Andrey Drobyshev, 2024/03/15
- [PATCH v3 1/7] qga: guest-get-fsinfo: add optional 'total-bytes-root' field, Andrey Drobyshev, 2024/03/15
- [PATCH v3 2/7] qga: introduce ga_run_command() helper for guest cmd execution, Andrey Drobyshev, 2024/03/15
- [PATCH v3 6/7] qga/commands-posix: don't do fork()/exec() when suspending via sysfs, Andrey Drobyshev, 2024/03/15
- [PATCH v3 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_command helper, Andrey Drobyshev, 2024/03/15
- Re: [PATCH v3 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_command helper,
Daniel P . Berrangé <=
- [PATCH v3 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper, Andrey Drobyshev, 2024/03/15
- [PATCH v3 5/7] qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper, Andrey Drobyshev, 2024/03/15
- [PATCH v3 3/7] qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper, Andrey Drobyshev, 2024/03/15