Re: [PATCH 6/7] target/i386: Implement mc->kvm_type() to get VM type

[Paolo Bonzini]

On Tue, Mar 19, 2024 at 3:15 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > +int kvm_get_vm_type(MachineState *ms, const char *vm_type)
>
> The 'vm_type' parameter is never used here. What value is it expected
> to have, and should be diagnosing an error if some unexpected value
> is provided.

It's the value of the kvm-type machine property, if any; but no x86
machine defines one, so right now it's always NULL. I left it in
because then it's clearer than this is an implementation of
mc->kvm_type, but I can remove it or pass it down to
x86_confidential_guest_kvm_type().

Paolo

> > +{
> > +    int kvm_type = KVM_X86_DEFAULT_VM;
> > +
> > +    if (ms->cgs) {
> > +        if (!object_dynamic_cast(OBJECT(ms->cgs), 
> > TYPE_X86_CONFIDENTIAL_GUEST)) {
> > +            error_report("configuration type %s not supported for x86 
> > guests",
> > +                         object_get_typename(OBJECT(ms->cgs)));
> > +            exit(1);
> > +        }
> > +        kvm_type = x86_confidential_guest_kvm_type(
> > +            X86_CONFIDENTIAL_GUEST(ms->cgs));
> > +    }
> > +
> > +    if (!kvm_is_vm_type_supported(kvm_type)) {
> > +        error_report("vm-type %s not supported by KVM", 
> > vm_type_name[kvm_type]);
> > +        exit(1);
> > +    }
> > +
> > +    return kvm_type;
> > +}
> > +
> >  bool kvm_has_smm(void)
> >  {
> >      return kvm_vm_check_extension(kvm_state, KVM_CAP_X86_SMM);
> > --
> > 2.44.0
> >
> >
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>