[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 24/24] smbios: add extra comments to smbios_get_table_legacy()
From: |
Michael S. Tsirkin |
Subject: |
[PULL 24/24] smbios: add extra comments to smbios_get_table_legacy() |
Date: |
Mon, 18 Mar 2024 12:17:04 -0400 |
From: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20240314152302.2324164-22-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/smbios/smbios_legacy.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/smbios/smbios_legacy.c b/hw/smbios/smbios_legacy.c
index 06907cd16c..c37a8ee821 100644
--- a/hw/smbios/smbios_legacy.c
+++ b/hw/smbios/smbios_legacy.c
@@ -151,6 +151,9 @@ uint8_t *smbios_get_table_legacy(size_t *length, Error
**errp)
smbios_entries_len = sizeof(uint16_t);
smbios_entries = g_malloc0(smbios_entries_len);
+ /*
+ * build a set of legacy smbios_table entries using user provided blobs
+ */
for (i = 0, usr_offset = 0; usr_blobs_sizes && i < usr_blobs_sizes->len;
i++)
{
@@ -166,6 +169,10 @@ uint8_t *smbios_get_table_legacy(size_t *length, Error
**errp)
table->header.length = cpu_to_le16(sizeof(*table) + size);
memcpy(table->data, header, size);
smbios_entries_len += sizeof(*table) + size;
+ /*
+ * update number of entries in the blob,
+ * see SeaBIOS: qemu_cfg_legacy():QEMU_CFG_SMBIOS_ENTRIES
+ */
(*(uint16_t *)smbios_entries) =
cpu_to_le16(le16_to_cpu(*(uint16_t *)smbios_entries) + 1);
usr_offset += size;
--
MST
- [PULL 14/24] smbios: build legacy mode code only for 'pc' machine, (continued)
- [PULL 14/24] smbios: build legacy mode code only for 'pc' machine, Michael S. Tsirkin, 2024/03/18
- [PULL 15/24] smbios: handle errors consistently, Michael S. Tsirkin, 2024/03/18
- [PULL 16/24] smbios: get rid of global smbios_ep_type, Michael S. Tsirkin, 2024/03/18
- [PULL 18/24] smbios: extend smbios-entry-point-type with 'auto' value, Michael S. Tsirkin, 2024/03/18
- [PULL 19/24] smbios: in case of entry point is 'auto' try to build v2 tables 1st, Michael S. Tsirkin, 2024/03/18
- [PULL 17/24] smbios: clear smbios_type4_count before building tables, Michael S. Tsirkin, 2024/03/18
- [PULL 20/24] smbios: error out when building type 4 table is not possible, Michael S. Tsirkin, 2024/03/18
- [PULL 21/24] tests: acpi/smbios: whitelist expected blobs, Michael S. Tsirkin, 2024/03/18
- [PULL 22/24] pc/q35: set SMBIOS entry point type to 'auto' by default, Michael S. Tsirkin, 2024/03/18
- [PULL 23/24] tests: acpi: update expected SSDT.dimmpxm blob, Michael S. Tsirkin, 2024/03/18
- [PULL 24/24] smbios: add extra comments to smbios_get_table_legacy(),
Michael S. Tsirkin <=
- Re: [PULL 00/24] virtio,pc,pci: bugfixes, Peter Maydell, 2024/03/19