[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/24] tests: smbios: add test for legacy mode CLI options
From: |
Michael S. Tsirkin |
Subject: |
[PULL 06/24] tests: smbios: add test for legacy mode CLI options |
Date: |
Mon, 18 Mar 2024 12:15:46 -0400 |
From: Igor Mammedov <imammedo@redhat.com>
Unfortunately having 2.0 machine type deprecated is not enough
to get rid of legacy SMBIOS handling since 'isapc' also uses
that and it's staying around.
Hence add test for CLI options handling to be sure that it
ain't broken during SMBIOS code refactoring.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-4-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/bios-tables-test.c | 17 +++++++++++++++++
tests/data/smbios/type11_blob.legacy | Bin 0 -> 10 bytes
2 files changed, 17 insertions(+)
create mode 100644 tests/data/smbios/type11_blob.legacy
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index a116f88e1d..d1ff4db7a2 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -2106,6 +2106,21 @@ static void test_acpi_pc_smbios_blob(void)
free_test_data(&data);
}
+static void test_acpi_isapc_smbios_legacy(void)
+{
+ uint8_t req_type11[] = { 1, 11 };
+ test_data data = {
+ .machine = "isapc",
+ .variant = ".pc_smbios_legacy",
+ .required_struct_types = req_type11,
+ .required_struct_types_len = ARRAY_SIZE(req_type11),
+ };
+
+ test_smbios("-smbios file=tests/data/smbios/type11_blob.legacy "
+ "-smbios type=1,family=TEST", &data);
+ free_test_data(&data);
+}
+
static void test_oem_fields(test_data *data)
{
int i;
@@ -2261,6 +2276,8 @@ int main(int argc, char *argv[])
test_acpi_pc_smbios_options);
qtest_add_func("acpi/piix4/smbios-blob",
test_acpi_pc_smbios_blob);
+ qtest_add_func("acpi/piix4/smbios-legacy",
+ test_acpi_isapc_smbios_legacy);
}
if (qtest_has_machine(MACHINE_Q35)) {
qtest_add_func("acpi/q35", test_acpi_q35_tcg);
diff --git a/tests/data/smbios/type11_blob.legacy
b/tests/data/smbios/type11_blob.legacy
new file mode 100644
index
0000000000000000000000000000000000000000..aef463aab903405958b0a85f85c5980671c08bee
GIT binary patch
literal 10
Rcmd;PW!S(N;u;*n000Tp0s;U4
literal 0
HcmV?d00001
--
MST
- [PULL 00/24] virtio,pc,pci: bugfixes, Michael S. Tsirkin, 2024/03/18
- [PULL 01/24] SMBIOS: fix long lines, Michael S. Tsirkin, 2024/03/18
- [PULL 03/24] docs/specs/pvpanic: mark shutdown event as not implemented, Michael S. Tsirkin, 2024/03/18
- [PULL 02/24] qapi: document PCIe Gen5/Gen6 speeds since 9.0, Michael S. Tsirkin, 2024/03/18
- [PULL 04/24] tests: smbios: make it possible to write SMBIOS only test, Michael S. Tsirkin, 2024/03/18
- [PULL 06/24] tests: smbios: add test for legacy mode CLI options,
Michael S. Tsirkin <=
- [PULL 05/24] tests: smbios: add test for -smbios type=11 option, Michael S. Tsirkin, 2024/03/18
- [PULL 07/24] smbios: cleanup smbios_get_tables() from legacy handling, Michael S. Tsirkin, 2024/03/18
- [PULL 08/24] smbios: get rid of smbios_smp_sockets global, Michael S. Tsirkin, 2024/03/18
- [PULL 10/24] smbios: avoid mangling user provided tables, Michael S. Tsirkin, 2024/03/18
- [PULL 11/24] smbios: don't check type4 structures in legacy mode, Michael S. Tsirkin, 2024/03/18
- [PULL 09/24] smbios: get rid of smbios_legacy global, Michael S. Tsirkin, 2024/03/18
- [PULL 12/24] smbios: add smbios_add_usr_blob_size() helper, Michael S. Tsirkin, 2024/03/18
- [PULL 13/24] smbios: rename/expose structures/bitmaps used by both legacy and modern code, Michael S. Tsirkin, 2024/03/18
- [PULL 14/24] smbios: build legacy mode code only for 'pc' machine, Michael S. Tsirkin, 2024/03/18
- [PULL 15/24] smbios: handle errors consistently, Michael S. Tsirkin, 2024/03/18