qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/3] kvm: add support for guest physical bits


From: Gerd Hoffmann
Subject: Re: [PATCH v3 2/3] kvm: add support for guest physical bits
Date: Mon, 18 Mar 2024 16:33:15 +0100

  Hi,

> > +    if (cpu->guest_phys_bits > cpu->host_phys_bits_limit) {
> > +        cpu->guest_phys_bits = cpu->host_phys_bits_limit;
> 
> host_phys_bits_limit is zero by default, so I think it is better to be
> like:
> 
>         if (cpu->host_phys_bits_limit &&
>             cpu->guest_phys_bits > cpu->host_phys_bits_limit) {
>             cpu->guest_phys_bits = cpu->host_phys_bits_limit;
>         }

Good point, fixed.

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]