qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user: replace calloc() with g_new0()


From: Alex Bennée
Subject: Re: [PATCH] linux-user: replace calloc() with g_new0()
Date: Sun, 17 Mar 2024 20:38:50 +0000
User-agent: mu4e 1.12.1; emacs 29.2

Nguyen Dinh Phi <phind.uet@gmail.com> writes:

> Use glib allocation as recommended by the coding convention
>
> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> ---
>  linux-user/main.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 9277df2e9d..149e35432e 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -928,11 +928,7 @@ int main(int argc, char **argv, char **envp)
>       * Prepare copy of argv vector for target.
>       */
>      target_argc = argc - optind;
> -    target_argv = calloc(target_argc + 1, sizeof (char *));
> -    if (target_argv == NULL) {
> -        (void) fprintf(stderr, "Unable to allocate memory for 
> target_argv\n");
> -        exit(EXIT_FAILURE);
> -    }
> +    target_argv = g_new0(char *, target_argc + 1);

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]