[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 8/9] tests/qemu-iotests: Fix some tests that use --image-opts for
From: |
Thomas Huth |
Subject: |
[PATCH 8/9] tests/qemu-iotests: Fix some tests that use --image-opts for other protocols |
Date: |
Fri, 15 Mar 2024 12:11:07 +0100 |
Tests 263, 284 and detect-zeroes-registered-buf use qemu-io
with --image-opts so we have to enforce IMGOPTSSYNTAX=true here
to get $TEST_IMG in shape for other protocols than "file".
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/263 | 6 ++++--
tests/qemu-iotests/284 | 7 +++----
tests/qemu-iotests/tests/detect-zeroes-registered-buf | 4 +++-
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/263 b/tests/qemu-iotests/263
index ec09b41405..44fdada0d6 100755
--- a/tests/qemu-iotests/263
+++ b/tests/qemu-iotests/263
@@ -34,6 +34,8 @@ _cleanup()
}
trap "_cleanup; exit \$status" 0 1 2 3 15
+IMGOPTSSYNTAX=true
+
# get standard environment, filters and checks
. ./common.rc
. ./common.filter
@@ -73,7 +75,7 @@ echo "testing LUKS qcow2 encryption"
echo
_make_test_img --object $SECRET -o
"encrypt.format=luks,encrypt.key-secret=sec0,encrypt.iter-time=10,cluster_size=64K"
$size
-_run_test "driver=$IMGFMT,encrypt.key-secret=sec0,file.filename=$TEST_IMG"
+_run_test "$TEST_IMG,encrypt.key-secret=sec0"
_cleanup_test_img
echo
@@ -82,7 +84,7 @@ echo
_make_test_img --object $SECRET -o
"encrypt.format=aes,encrypt.key-secret=sec0,cluster_size=64K" $size
-_run_test "driver=$IMGFMT,encrypt.key-secret=sec0,file.filename=$TEST_IMG"
+_run_test "$TEST_IMG,encrypt.key-secret=sec0"
_cleanup_test_img
diff --git a/tests/qemu-iotests/284 b/tests/qemu-iotests/284
index 5a82639e7f..722267486d 100755
--- a/tests/qemu-iotests/284
+++ b/tests/qemu-iotests/284
@@ -33,6 +33,8 @@ _cleanup()
}
trap "_cleanup; exit \$status" 0 1 2 3 15
+IMGOPTSSYNTAX=true
+
# get standard environment, filters and checks
. ./common.rc
. ./common.filter
@@ -47,14 +49,12 @@ size=1M
SECRET="secret,id=sec0,data=astrochicken"
-IMGSPEC="driver=$IMGFMT,file.filename=$TEST_IMG,encrypt.key-secret=sec0"
QEMU_IO_OPTIONS=$QEMU_IO_OPTIONS_NO_FMT
_run_test()
{
- IMGOPTSSYNTAX=true
OLD_TEST_IMG="$TEST_IMG"
-
TEST_IMG="driver=$IMGFMT,file.filename=$TEST_IMG,encrypt.key-secret=sec0"
+ TEST_IMG="$TEST_IMG,encrypt.key-secret=sec0"
QEMU_IMG_EXTRA_ARGS="--image-opts --object $SECRET"
echo
@@ -78,7 +78,6 @@ _run_test()
TEST_IMG="$OLD_TEST_IMG"
QEMU_IMG_EXTRA_ARGS=
- IMGOPTSSYNTAX=
}
diff --git a/tests/qemu-iotests/tests/detect-zeroes-registered-buf
b/tests/qemu-iotests/tests/detect-zeroes-registered-buf
index edb5f2cee5..5eaf34e5a6 100755
--- a/tests/qemu-iotests/tests/detect-zeroes-registered-buf
+++ b/tests/qemu-iotests/tests/detect-zeroes-registered-buf
@@ -36,6 +36,8 @@ _cleanup()
}
trap "_cleanup; exit \$status" 0 1 2 3 15
+IMGOPTSSYNTAX=true
+
# get standard environment, filters and checks
cd ..
. ./common.rc
@@ -46,7 +48,7 @@ _supported_proto generic
size=128M
_make_test_img $size
-IMGSPEC="driver=$IMGFMT,file.filename=$TEST_IMG,discard=unmap,detect-zeroes=unmap"
+IMGSPEC="$TEST_IMG,discard=unmap,detect-zeroes=unmap"
echo
echo "== writing zero buffer to image =="
--
2.44.0
- [PATCH 0/9] tests/qemu-iotests: Fix running with "check -ssh -qcow2", Thomas Huth, 2024/03/15
- [PATCH 3/9] tests/qemu-iotests: Restrict test 114 to the 'file' protocol, Thomas Huth, 2024/03/15
- [PATCH 1/9] tests/qemu-iotests: Fix test 033 for running with non-file protocols, Thomas Huth, 2024/03/15
- [PATCH 2/9] tests/qemu-iotests: Restrict test 066 to the 'file' protocol, Thomas Huth, 2024/03/15
- [PATCH 5/9] tests/qemu-iotests: Restrict test 134 and 158 to the 'file' protocol, Thomas Huth, 2024/03/15
- [PATCH 4/9] tests/qemu-iotests: Restrict test 130 to the 'file' protocol, Thomas Huth, 2024/03/15
- [PATCH 6/9] tests/qemu-iotests: Restrict test 156 to the 'file' protocol, Thomas Huth, 2024/03/15
- [PATCH 7/9] tests/qemu-iotests: Restrict tests that use --image-opts to the 'file' protocol, Thomas Huth, 2024/03/15
- [PATCH 9/9] tests/qemu-iotests: Restrict tests using "--blockdev file" to the file protocol, Thomas Huth, 2024/03/15
- [PATCH 8/9] tests/qemu-iotests: Fix some tests that use --image-opts for other protocols,
Thomas Huth <=
- Re: [PATCH 0/9] tests/qemu-iotests: Fix running with "check -ssh -qcow2", Kevin Wolf, 2024/03/18