Re: [PATCH 12/12] vdpa: fix network breakage after cancelling migration

[Michael Tokarev]

13.03.2024 22:10, Si-Wei Liu wrote:
> On 3/13/2024 11:12 AM, Michael Tokarev wrote:
..
> > Is this a -stable material?
> Probably yes, the pre-requisites of this patch are PATCH #10 and #11 from this 
> series (where SVQ_TSTATE_DISABLING gets defined and set).
>
> > If yes, is it also applicable for stable-7.2 (mentioned commit is in 7.2.0),
> > which lacks v7.2.0-2327-gb276524386 "vdpa: Remember last call fd set",
> > or should this one also be picked up?
> Eugenio can judge, but seems to me the relevant code path cannot be effectively called as the dynamic SVQ feature (switching over to SVQ dynamically 
> when migration is started) is not supported from 7.2. Maybe not worth it to cherry-pick this one to 7.2. Cherry-pick to stable-8.0 and above should be 
> applicable though (it needs some tweaks on patch #10 to move svq_switching from @struct VhostVDPAShared to @struct vhost_vdpa).

Uhh.  That's a bit larger than I thought.  With this amount of prepreqs
and manual tweaking, and with the fact this whole thing introduces Yet
Another State value, - let's omit this one.  Or at the very least I'd
love to have actual real-life testcase and a clean backport to 8.2 of
all the required changes.

Thanks,

/mjt