Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

[Michael Tokarev]

10.03.2024 21:13, Richard Henderson wrote:
> On 3/9/24 08:40, Michael Tokarev wrote:
...
> > I tried to pick this one up for stable-7.2 (since the fix is for older commit),
> > and faced a fun issue in this change to tests/tcg/aarch64/Makefile.target,
> > since 7.2. doesn't have CROSS_AS_HAS_ARMV9_SME yet.  I went on and found out
> > that the following commits:
> >
> > v7.2.0-374-gbc6bd20ee3  target/arm: align exposed ID registers with Linux
> > v8.0.0-2358-g3dc2afeab2 tests/tcg/aarch64/sysregs.c: Use S syntax for 
> > id_aa64zfr0_el1
> >                          and id_aa64smfr0_el1
> > v8.0.0-2361-g1f51573f79 target/arm: Fix SME full tile indexing
> >
> > applies to 7.2, and lets this "Fix 32-bit SMOPA" change to apply cleanly,
> > including this very change in Makefile.target.
> >
> > Now, 1f51573f79 "Fix SME full tile indexing" is Cc'd qemu-stable already, but
> > it is not in 7.2.x for some reason which I don't remember anymore, so it is
> > a good one to pick up already.  3dc2afeab is tests-only.
>
> Oh wow, I didn't expect the fix to get propagated back that far.
> I was expecting only back into the 8.x series...
>
> > And bc6bd20ee3 (from Dec-2022) seems like a good candidate too, is it not?
>
> Sure, couldn't hurt.
>
> If it all applies without drama, all is well.

While it goes fine, it doesn't quite work actually:

https://gitlab.com/qemu-project/qemu/-/jobs/6386966720#L2482

timeout --foreground 90  
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/qemu-aarch64  
sme-smopa-1 >  sme-smopa-1.out
warning: TCG temporary leaks before 0000000000400714
qemu-aarch64: ../tcg/tcg.c:1052: tcg_temp_free_internal: Assertion 
`ts->temp_allocated != 0' failed.
timeout: the monitored command dumped core
Trace/breakpoint trap
make[1]: *** [Makefile:170: run-sme-smopa-1] Error 133
make[1]: Leaving directory 
'/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/tests/tcg/aarch64-linux-user'
make[1]: *** Waiting for unfinished jobs....
make[1]: Entering directory 
'/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/tests/tcg/aarch64-linux-user'
timeout --foreground 90  
/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/qemu-aarch64  
sme-smopa-2 >  sme-smopa-2.out
warning: TCG temporary leaks before 0000000000400730
qemu-aarch64: ../tcg/tcg.c:1052: tcg_temp_free_internal: Assertion 
`ts->temp_allocated != 0' failed.
timeout: the monitored command dumped core
Trace/breakpoint trap

Does it make sense to pick this for 7.2 with the above failures?

Unfortunately this test does not run on a private repository clone on gitlab,
that's why I haven't noticed this immediately.

Thanks,

/mjt