[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] linux-aio: add IO_CMD_FDSYNC command support
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v3] linux-aio: add IO_CMD_FDSYNC command support |
|
Date: |
Wed, 13 Mar 2024 13:56:37 -0400 |
On Wed, Mar 13, 2024 at 10:49:31PM +0530, Prasad Pandit wrote:
> On Wed, 13 Mar 2024 at 20:48, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > +extern bool laio_has_fdsync(int);
> > Please declare this in include/block/raw-aio.h alongside the other laio
> > APIs.
> >
> > FDSYNC support should be probed at open() time and the result should be
> > stored in a new bool field like s->laio_supports_fdsync. That way the
> > cost of laio_has_fdsync() on every flush request is avoided.
>
> * Okay. Here 's' is a BDRVRawState object and file open seems to
> happen in the raw_open_common() function? I'll move the
> laio_has_fdsync() call there and see how it works.
Yes. Thanks!
Stefan
signature.asc
Description: PGP signature