qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] tests/avocado: use OpenBSD 7.4 for sbsa-ref


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/3] tests/avocado: use OpenBSD 7.4 for sbsa-ref
Date: Wed, 13 Mar 2024 17:32:28 +0100
User-agent: Mozilla Thunderbird

On 13/3/24 16:06, Philippe Mathieu-Daudé wrote:
On 13/3/24 14:39, Marcin Juszkiewicz wrote:
W dniu 13.03.2024 o 12:44, Philippe Mathieu-Daudé pisze:
-        :avocado: tags=cpu:cortex-a57
+        :avocado: tags=cpu:cortex-a57,os:openbsd

IIRC for some reason we must use one tag per line... Even if
named 'tags', this is handled as a single tag, so we couldn't
filter on "os:openbsd". We need:

   :avocado: tags=cpu:cortex-a57
   :avocado: tags=os:openbsd

OK. It worked when I tested this way:

$ make check-avocado AVOCADO_TAGS='machine:sbsa-ref,os:openbsd'
[..]
  (1/3) tests/avocado/machine_aarch64_sbsaref.py:Aarch64SbsarefMachine.test_sbsaref_openbsd_cortex_a57: PASS (16.18 s)   (2/3) tests/avocado/machine_aarch64_sbsaref.py:Aarch64SbsarefMachine.test_sbsaref_openbsd_neoverse_n1: PASS (16.06 s)

$ make check-avocado AVOCADO_TAGS='os:openbsd'

Oh great news, TIL!

Still thinking a bit about it, using one line for one tag
reduce patch churn when adding/removing tags, and eases
rebasing / cherry-picking.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]