[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for 9.0] migration: Skip only empty block devices
From: |
Kevin Wolf |
Subject: |
Re: [PATCH for 9.0] migration: Skip only empty block devices |
Date: |
Wed, 13 Mar 2024 10:57:18 +0100 |
Am 12.03.2024 um 13:27 hat Peter Xu geschrieben:
> On Tue, Mar 12, 2024 at 01:04:31PM +0100, Cédric Le Goater wrote:
> > The block .save_setup() handler calls a helper routine
> > init_blk_migration() which builds a list of block devices to take into
> > account for migration. When one device is found to be empty (sectors
> > == 0), the loop exits and all the remaining devices are ignored. This
> > is a regression introduced when bdrv_iterate() was removed.
> >
> > Change that by skipping only empty devices.
> >
> > Cc: Markus Armbruster <armbru@redhat.com>
> > Suggested: Kevin Wolf <kwolf@redhat.com>
>
> This should be:
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
>
> I think the missed "by" caused Kevin not in the cc list, I added Kevin in.
>
> I'll hold a bit for Kevin to ACK, no repost needed just for above; I can
> fix it.
Thanks.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>