[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 11/24] net: Use virtual time for net announce
|
From: |
Nicholas Piggin |
|
Subject: |
Re: [PATCH v4 11/24] net: Use virtual time for net announce |
|
Date: |
Wed, 13 Mar 2024 17:09:51 +1000 |
On Tue Mar 12, 2024 at 9:12 PM AEST, Pavel Dovgalyuk wrote:
> On 12.03.2024 14:05, Nicholas Piggin wrote:
> > On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote:
> >> This won't work, as needed. Announce timer can't be enabled, because
> >> it is set in post_load function. Therefore announce callbacks break
> >> the replay, when virtio-net is used with snapshots.
> >
> > I see. Is that somehow marked as being incompatible with rr?
>
> Here's the prior discussion on it:
> https://lore.kernel.org/qemu-devel/8735ovx0zd.fsf@linaro.org/t/
Actually I don't know if it's so simple. If VIRTIO_NET_F_GUEST_ANNOUNCE
is clear then AFAIKS it sends a RARP packet instead. Also the timer can
be triggered for other reasons than migration. Not quite sure how that
all fits together.
I guess record/replay would just have to disable it entirely. We could
support it if we had a ANNOUNCE event I guess.
Thanks,
Nick
- Re: [PATCH v4 06/24] chardev: set record/replay on the base device of a muxed device, (continued)
- [PATCH v4 07/24] replay: Fix migration use of clock, Nicholas Piggin, 2024/03/11
- [PATCH v4 08/24] replay: Fix migration replay_mutex locking, Nicholas Piggin, 2024/03/11
- [PATCH v4 09/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Nicholas Piggin, 2024/03/11
- [PATCH v4 10/24] virtio-net: Use virtual time for RSC timers, Nicholas Piggin, 2024/03/11
- [PATCH v4 11/24] net: Use virtual time for net announce, Nicholas Piggin, 2024/03/11
[PATCH v4 12/24] savevm: Fix load_snapshot error path crash, Nicholas Piggin, 2024/03/11
[PATCH v4 13/24] tests/avocado: replay_linux.py remove the timeout expected guards, Nicholas Piggin, 2024/03/11
[PATCH v4 15/24] tests/avocado: reverse_debugging.py add test for x86-64 q35 machine, Nicholas Piggin, 2024/03/11
[PATCH v4 17/24] tests/avocado: reverse_debugging.py stop VM before sampling icount, Nicholas Piggin, 2024/03/11
[PATCH v4 18/24] tests/avocado: reverse_debugging reverse-step at the end of the trace, Nicholas Piggin, 2024/03/11
[PATCH v4 14/24] tests/avocado/reverse_debugging.py: mark aarch64 and pseries as not flaky, Nicholas Piggin, 2024/03/11
[PATCH v4 16/24] tests/avocado: reverse_debugging.py verify addresses between record and replay, Nicholas Piggin, 2024/03/11
[PATCH v4 19/24] tests/avocado: reverse_debugging.py add snapshot testing, Nicholas Piggin, 2024/03/11
[PATCH v4 21/24] tests/avocado: reverse_debugging.py test auto-snapshot mode, Nicholas Piggin, 2024/03/11
[PATCH v4 20/24] replay: simple auto-snapshot mode for record, Nicholas Piggin, 2024/03/11