[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 13/23] qapi/schema: fix QAPISchemaArrayType.check's call to re
From: |
John Snow |
Subject: |
[PATCH v4 13/23] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type |
Date: |
Wed, 13 Mar 2024 00:41:17 -0400 |
Adjust the expression at the callsite to work around mypy's weak type
introspection that believes this expression can resolve to
QAPISourceInfo; it cannot.
(Fundamentally: self.info only resolves to false in a boolean expression
when it is None; therefore this expression may only ever produce
Optional[str]. mypy does not know that 'info', when it is a
QAPISourceInfo object, cannot ever be false.)
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/schema.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 58ec3a7c41c..22e065fc13d 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -395,7 +395,7 @@ def check(self, schema):
super().check(schema)
self.element_type = schema.resolve_type(
self._element_type_name, self.info,
- self.info and self.info.defn_meta)
+ self.info.defn_meta if self.info else None)
assert not isinstance(self.element_type, QAPISchemaArrayType)
def set_module(self, schema):
--
2.44.0
- [PATCH v4 00/23] qapi: statically type schema.py, John Snow, 2024/03/13
- [PATCH v4 03/23] qapi: sort pylint suppressions, John Snow, 2024/03/13
- [PATCH v4 01/23] qapi/parser: fix typo - self.returns.info => self.errors.info, John Snow, 2024/03/13
- [PATCH v4 09/23] qapi/schema: adjust type narrowing for mypy's benefit, John Snow, 2024/03/13
- [PATCH v4 04/23] qapi/schema: add pylint suppressions, John Snow, 2024/03/13
- [PATCH v4 13/23] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type,
John Snow <=
- [PATCH v4 02/23] qapi/parser: shush up pylint, John Snow, 2024/03/13
- [PATCH v4 12/23] qapi: use schema.resolve_type instead of schema.lookup_type, John Snow, 2024/03/13
- [PATCH v4 18/23] qapi/schema: assert inner type of QAPISchemaVariants in check_clash(), John Snow, 2024/03/13
- [PATCH v4 14/23] qapi/schema: assert info is present when necessary, John Snow, 2024/03/13
- [PATCH v4 07/23] qapi/schema: declare type for QAPISchemaArrayType.element_type, John Snow, 2024/03/13
- [PATCH v4 05/23] qapi: create QAPISchemaDefinition, John Snow, 2024/03/13