Re: [PATCH v2 4/5] plugins: conditional callbacks

[Richard Henderson]

On 3/11/24 21:54, Pierrick Bouvier wrote:
> +/**
> + * enum qemu_plugin_cond - condition to enable callback
> + *
> + * @QEMU_PLUGIN_COND_NEVER: false
> + * @QEMU_PLUGIN_COND_ALWAYS: true
> + * @QEMU_PLUGIN_COND_EQ: is equal?
> + * @QEMU_PLUGIN_COND_NE: is not equal?
> + * @QEMU_PLUGIN_COND_LT: is less than?
> + * @QEMU_PLUGIN_COND_LE: is less than or equal?
> + * @QEMU_PLUGIN_COND_GT: is greater than?
> + * @QEMU_PLUGIN_COND_GE: is greater than or equal?
> + */
> +enum qemu_plugin_cond {
> +    QEMU_PLUGIN_COND_NEVER,
> +    QEMU_PLUGIN_COND_ALWAYS,
> +    QEMU_PLUGIN_COND_EQ,
> +    QEMU_PLUGIN_COND_NE,
> +    QEMU_PLUGIN_COND_LT,
> +    QEMU_PLUGIN_COND_LE,
> +    QEMU_PLUGIN_COND_GT,
> +    QEMU_PLUGIN_COND_GE,
> +};

Do you really need to expose ALWAYS/NEVER?
I guess these are all unsigned?  Would it be clearer to add "U" suffixes?


r~