[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/8] linux-user/elfload: Don't close an unopened file descriptor
From: |
Richard Henderson |
Subject: |
[PULL 5/8] linux-user/elfload: Don't close an unopened file descriptor |
Date: |
Tue, 12 Mar 2024 08:41:12 -1000 |
Fixes Coverity CID: 1534964
Fixes: 106f8da664 ("linux-user/elfload: Open core file after vma_init")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 4dbca05646..26d4c1d6b3 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -4522,7 +4522,9 @@ static int elf_core_dump(int signr, const CPUArchState
*env)
ret = -errno;
mmap_unlock();
cpu_list_unlock();
- close(fd);
+ if (fd >= 0) {
+ close(fd);
+ }
return ret;
}
#endif /* USE_ELF_CORE_DUMP */
--
2.34.1
- [PULL 0/8] tcg + linux-user patch queue, Richard Henderson, 2024/03/12
- [PULL 1/8] linux-user: Add FIFREEZE and FITHAW ioctls, Richard Henderson, 2024/03/12
- [PULL 3/8] linux-user: Implement PR_{GET,SET}_SPECULATION_CTRL, Richard Henderson, 2024/03/12
- [PULL 2/8] linux-user: Implement PR_{GET,SET}_CHILD_SUBREAPER, Richard Henderson, 2024/03/12
- [PULL 4/8] linux-user: Implement PR_GET_TID_ADDRESS, Richard Henderson, 2024/03/12
- [PULL 8/8] tcg/aarch64: Fix tcg_out_brcond for test comparisons, Richard Henderson, 2024/03/12
- [PULL 6/8] linux-user/elfload: Fully initialize struct target_elf_prpsinfo, Richard Henderson, 2024/03/12
- [PULL 5/8] linux-user/elfload: Don't close an unopened file descriptor,
Richard Henderson <=
- [PULL 7/8] tcg/aarch64: Fix tcg_out_cmp for test comparisons, Richard Henderson, 2024/03/12
- Re: [PULL 0/8] tcg + linux-user patch queue, Peter Maydell, 2024/03/13