[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/8] gdbstub: Rename back gdb_handlesig
From: |
Alex Bennée |
Subject: |
[PULL 3/8] gdbstub: Rename back gdb_handlesig |
Date: |
Tue, 12 Mar 2024 11:25:27 +0000 |
From: Gustavo Romero <gustavo.romero@linaro.org>
Rename gdb_handlesig_reason back to gdb_handlesig. There is no need to
add a wrapper for gdb_handlesig and rename it when a new parameter is
added.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240309030901.1726211-2-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/include/gdbstub/user.h b/include/gdbstub/user.h
index 4c4e5c4c58..4fc88f8a25 100644
--- a/include/gdbstub/user.h
+++ b/include/gdbstub/user.h
@@ -10,7 +10,7 @@
#define GDBSTUB_USER_H
/**
- * gdb_handlesig_reason() - yield control to gdb
+ * gdb_handlesig() - yield control to gdb
* @cpu: CPU
* @sig: if non-zero, the signal number which caused us to stop
* @reason: stop reason for stop reply packet or NULL
@@ -25,18 +25,7 @@
* or 0 if no signal should be delivered, ie the signal that caused
* us to stop should be ignored.
*/
-int gdb_handlesig_reason(CPUState *, int, const char *);
-
-/**
- * gdb_handlesig() - yield control to gdb
- * @cpu CPU
- * @sig: if non-zero, the signal number which caused us to stop
- * @see gdb_handlesig_reason()
- */
-static inline int gdb_handlesig(CPUState *cpu, int sig)
-{
- return gdb_handlesig_reason(cpu, sig, NULL);
-}
+int gdb_handlesig(CPUState *, int, const char *);
/**
* gdb_signalled() - inform remote gdb of sig exit
diff --git a/gdbstub/user.c b/gdbstub/user.c
index 7f9f19a124..520987fddc 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -190,7 +190,7 @@ void gdb_qemu_exit(int code)
exit(code);
}
-int gdb_handlesig_reason(CPUState *cpu, int sig, const char *reason)
+int gdb_handlesig(CPUState *cpu, int sig, const char *reason)
{
char buf[256];
int n;
@@ -746,7 +746,7 @@ void gdb_breakpoint_remove_all(CPUState *cs)
void gdb_syscall_handling(const char *syscall_packet)
{
gdb_put_packet(syscall_packet);
- gdb_handlesig(gdbserver_state.c_cpu, 0);
+ gdb_handlesig(gdbserver_state.c_cpu, 0, NULL);
}
static bool should_catch_syscall(int num)
@@ -764,7 +764,7 @@ void gdb_syscall_entry(CPUState *cs, int num)
{
if (should_catch_syscall(num)) {
g_autofree char *reason = g_strdup_printf("syscall_entry:%x;", num);
- gdb_handlesig_reason(cs, gdb_target_sigtrap(), reason);
+ gdb_handlesig(cs, gdb_target_sigtrap(), reason);
}
}
@@ -772,7 +772,7 @@ void gdb_syscall_return(CPUState *cs, int num)
{
if (should_catch_syscall(num)) {
g_autofree char *reason = g_strdup_printf("syscall_return:%x;", num);
- gdb_handlesig_reason(cs, gdb_target_sigtrap(), reason);
+ gdb_handlesig(cs, gdb_target_sigtrap(), reason);
}
}
diff --git a/linux-user/main.c b/linux-user/main.c
index 41caa77cb5..55aa11c9b4 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -1018,7 +1018,7 @@ int main(int argc, char **argv, char **envp)
gdbstub);
exit(EXIT_FAILURE);
}
- gdb_handlesig(cpu, 0);
+ gdb_handlesig(cpu, 0, NULL);
}
#ifdef CONFIG_SEMIHOSTING
diff --git a/linux-user/signal.c b/linux-user/signal.c
index cc7dd78e41..bca44c295d 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -1180,7 +1180,7 @@ static void handle_pending_signal(CPUArchState *cpu_env,
int sig,
/* dequeue signal */
k->pending = 0;
- sig = gdb_handlesig(cpu, sig);
+ sig = gdb_handlesig(cpu, sig, NULL);
if (!sig) {
sa = NULL;
handler = TARGET_SIG_IGN;
--
2.39.2
- [PULL for 9.0 0/8] final maintainer updates (testing, gdbstub), Alex Bennée, 2024/03/12
- [PULL 3/8] gdbstub: Rename back gdb_handlesig,
Alex Bennée <=
- [PULL 1/8] gitlab: aggressively avoid extra GIT data, Alex Bennée, 2024/03/12
- [PULL 2/8] tests/vm: ensure we build everything by default, Alex Bennée, 2024/03/12
- [PULL 7/8] tests/tcg: Add multiarch test for Xfer:siginfo:read stub, Alex Bennée, 2024/03/12
- [PULL 5/8] gdbstub: Save target's siginfo, Alex Bennée, 2024/03/12
- [PULL 6/8] gdbstub: Add Xfer:siginfo:read stub, Alex Bennée, 2024/03/12
- [PULL 8/8] gdbstub: Fix double close() of the follow-fork-mode socket, Alex Bennée, 2024/03/12
- [PULL 4/8] linux-user: Move tswap_siginfo out of target code, Alex Bennée, 2024/03/12
- Re: [PULL for 9.0 0/8] final maintainer updates (testing, gdbstub), Peter Maydell, 2024/03/12