[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gdbstub: Fix double close() of the follow-fork-mode socket
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH] gdbstub: Fix double close() of the follow-fork-mode socket |
|
Date: |
Tue, 12 Mar 2024 08:10:48 +0000 |
|
User-agent: |
mu4e 1.12.1; emacs 29.1 |
Ilya Leoshkevich <iii@linux.ibm.com> writes:
> When the terminal GDB_FORK_ENABLED state is reached, the coordination
> socket is not needed anymore and is therefore closed. However, if there
> is a communication error between QEMU gdbstub and GDB, the generic
> error handling code attempts to close it again.
>
> Fix by closing it later - before returning - instead.
>
> Fixes: Coverity CID 1539966
> Fixes: d547e711a8a5 ("gdbstub: Implement follow-fork-mode child")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Queued to gdbstub/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro