[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 8/8] Add negative tests to validate migration QAPIs
From: |
Het Gala |
Subject: |
[PATCH v5 8/8] Add negative tests to validate migration QAPIs |
Date: |
Mon, 11 Mar 2024 21:53:58 +0000 |
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala <het.gala@nutanix.com>
Suggested-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
---
tests/qtest/migration-test.c | 53 ++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 392d5d0b62..9e3146d23f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -2608,6 +2608,55 @@ static void test_validate_uuid_dst_not_set(void)
do_test_validate_uuid(&args, false);
}
+static void do_test_validate_uri_channel(MigrateCommon *args)
+{
+ QTestState *from, *to;
+
+ if (test_migrate_start(&from, &to, args->listen_uri, &args->start)) {
+ return;
+ }
+
+ /* Wait for the first serial output from the source */
+ wait_for_serial("src_serial");
+
+ /*
+ * 'uri' and 'channels' validation is checked even before the migration
+ * starts.
+ */
+ migrate_qmp_fail(from, args->connect_uri, args->connect_channels, "{}");
+ test_migrate_end(from, to, false);
+}
+
+static void test_validate_uri_channels_both_set(void)
+{
+ MigrateCommon args = {
+ .start = {
+ .hide_stderr = true,
+ },
+ .listen_uri = "defer",
+ .connect_uri = "tcp:127.0.0.1:0",
+ .connect_channels = "[ { 'channel-type': 'main',"
+ " 'addr': { 'transport': 'socket',"
+ " 'type': 'inet',"
+ " 'host': '127.0.0.1',"
+ " 'port': '0' } } ]",
+ };
+
+ do_test_validate_uri_channel(&args);
+}
+
+static void test_validate_uri_channels_none_set(void)
+{
+ MigrateCommon args = {
+ .start = {
+ .hide_stderr = true,
+ },
+ .listen_uri = "defer",
+ };
+
+ do_test_validate_uri_channel(&args);
+}
+
/*
* The way auto_converge works, we need to do too many passes to
* run this test. Auto_converge logic is only run once every
@@ -3674,6 +3723,10 @@ int main(int argc, char **argv)
test_validate_uuid_src_not_set);
migration_test_add("/migration/validate_uuid_dst_not_set",
test_validate_uuid_dst_not_set);
+ migration_test_add("/migration/validate_uri/channels/both_set",
+ test_validate_uri_channels_both_set);
+ migration_test_add("/migration/validate_uri/channels/none_set",
+ test_validate_uri_channels_none_set);
/*
* See explanation why this test is slow on function definition
*/
--
2.22.3
- [PATCH v5 0/8] qtest: migration: Add tests for introducing 'channels' argument in migrate QAPIs, Het Gala, 2024/03/11
- [PATCH v5 4/8] Add channels parameter in migrate_qmp_fail, Het Gala, 2024/03/11
- [PATCH v5 1/8] Add 'to' object into migrate_qmp(), Het Gala, 2024/03/11
- [PATCH v5 2/8] Replace connect_uri and move migrate_get_socket_address inside migrate_qmp, Het Gala, 2024/03/11
- [PATCH v5 3/8] Replace migrate_get_connect_uri inplace of migrate_get_socket_address, Het Gala, 2024/03/11
- [PATCH v5 8/8] Add negative tests to validate migration QAPIs,
Het Gala <=
- [PATCH v5 7/8] Add multifd_tcp_plain test using list of channels instead of uri, Het Gala, 2024/03/11
- [PATCH v5 5/8] Add migrate_set_ports into migrate_qmp to update migration port value, Het Gala, 2024/03/11
- [PATCH v5 6/8] Add channels parameter in migrate_qmp, Het Gala, 2024/03/11
- Re: [PATCH v5 0/8] qtest: migration: Add tests for introducing 'channels' argument in migrate QAPIs, Het Gala, 2024/03/12