[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 11/13] target/ppc: Make checkstop actually stop the system
From: |
Nicholas Piggin |
Subject: |
[PATCH 11/13] target/ppc: Make checkstop actually stop the system |
Date: |
Tue, 12 Mar 2024 04:51:53 +1000 |
checkstop state does not halt the system, interrupts continue to be
serviced, and other CPUs run. Make it stop the machine with
qemu_system_guest_panicked.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
target/ppc/excp_helper.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 98952de267..9aca4a1489 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -19,6 +19,8 @@
#include "qemu/osdep.h"
#include "qemu/main-loop.h"
#include "qemu/log.h"
+#include "sysemu/sysemu.h"
+#include "sysemu/runstate.h"
#include "cpu.h"
#include "exec/exec-all.h"
#include "internal.h"
@@ -432,15 +434,22 @@ static void powerpc_mcheck_checkstop(CPUPPCState *env)
return;
}
+ /*
+ * This stops the machine and logs CPU state without killing QEMU
+ * (like cpu_abort()) so the machine can still be debugged (because
+ * it is often a guest error).
+ */
+
/* Machine check exception is not enabled. Enter checkstop state. */
fprintf(stderr, "Machine check while not allowed. "
"Entering checkstop state\n");
if (qemu_log_separate()) {
qemu_log("Machine check while not allowed. "
"Entering checkstop state\n");
- }
- cs->halted = 1;
- cpu_interrupt_exittb(cs);
+
+ qemu_system_guest_panicked(NULL);
+
+ cpu_loop_exit_noexc(cs);
}
static void powerpc_excp_40x(PowerPCCPU *cpu, int excp)
--
2.42.0
- [PATCH 08/13] ppc/pnv: Set POWER9, POWER10 ibm,pa-features bits, (continued)
- [PATCH 09/13] target/ppc: Prevent supervisor from modifying MSR[ME], Nicholas Piggin, 2024/03/11
- [PATCH 10/13] spapr: set MSR[ME] and MSR[FP] on client entry, Nicholas Piggin, 2024/03/11
- [PATCH 11/13] target/ppc: Make checkstop actually stop the system,
Nicholas Piggin <=
- [PATCH 12/13] target/ppc: improve checkstop logging, Nicholas Piggin, 2024/03/11
- [PATCH 13/13] target/ppc: Implement attn instruction on BookS 64-bit processors, Nicholas Piggin, 2024/03/11
- Re: [PATCH 00/13] misc ppc patches, Philippe Mathieu-Daudé, 2024/03/11