[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 00/19] contrib/elf2dmp: Improve robustness
From: |
Peter Maydell |
Subject: |
Re: [PATCH v4 00/19] contrib/elf2dmp: Improve robustness |
Date: |
Mon, 11 Mar 2024 17:09:27 +0000 |
On Thu, 7 Mar 2024 at 10:20, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> elf2dmp sometimes fails to work with partially corrupted dumps, and also
> emits warnings when sanitizers are in use. This series are collections
> of changes to improve the situation.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
Thanks for this -- I've taken it via target-arm.next since I
want to make another pullreq for softfreeze anyway.
I didn't take the "Build only for little endian host" patch. I thought
about it, and decided that on balance it was probably best not to:
in practice we haven't had anybody say "I tried to run this on a BE
host and it didn't work" (unsurprising, most users especially of Windows
VMs will be on LE hosts), and if we do stop building it for BE this
seems like it might well create work for downstream distros who might
have to make their package creation deal with "this binary doesn't
get built on these hosts" (and then remove that handling again in future
if we ever fix the endianness bugs).
thanks
-- PMM
- Re: [PATCH v4 15/19] MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer, (continued)
- [PATCH v4 12/19] contrib/elf2dmp: Ensure segment fits in file, Akihiko Odaki, 2024/03/07
- [PATCH v4 16/19] contrib/elf2dmp: Build only for little endian host, Akihiko Odaki, 2024/03/07
- [PATCH v4 17/19] contrib/elf2dmp: Use GPtrArray, Akihiko Odaki, 2024/03/07
- [PATCH v4 18/19] contrib/elf2dmp: Clamp QEMU note to file size, Akihiko Odaki, 2024/03/07
- [PATCH v4 13/19] contrib/elf2dmp: Use lduw_le_p() to read PDB, Akihiko Odaki, 2024/03/07
- [PATCH v4 19/19] contrib/elf2dmp: Ensure phdrs fit in file, Akihiko Odaki, 2024/03/07
- Re: [PATCH v4 00/19] contrib/elf2dmp: Improve robustness, Viktor Prutyanov, 2024/03/10
- Re: [PATCH v4 00/19] contrib/elf2dmp: Improve robustness,
Peter Maydell <=