Re: [PATCH v2] hw: gpio: introduce pcf8574 driver

[Philippe Mathieu-Daudé]

On 11/3/24 08:09, Dmitriy Sharikhin wrote:
> NXP PCF8574 and compatible ICs are simple I2C GPIO expanders.
> PCF8574 incorporates quasi-bidirectional IO, and simple
> communication protocol, when IO read is I2C byte read, and
> IO write is I2C byte write. User can think of it as
> open-drain port, when line high state is input and line low
> state is output.
>
> Signed-off-by: Dmitrii Sharikhin <d.sharikhin@yadro.com>
> ---
>   MAINTAINERS               |   6 ++
>   hw/gpio/Kconfig           |   4 +
>   hw/gpio/meson.build       |   1 +
>   hw/gpio/pcf8574.c         | 162 ++++++++++++++++++++++++++++++++++++++
>   include/hw/gpio/pcf8574.h |  15 ++++
>   5 files changed, 188 insertions(+)
>   create mode 100644 hw/gpio/pcf8574.c
>   create mode 100644 include/hw/gpio/pcf8574.h

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Unfortunately your patch doesn't apply anymore:

Total patches: 1 (cherrypicked: 
<56678f4f0c1e526b7b5a04104171e4feb372e7c2.camel@yadro.com>)
Applying: hw: gpio: introduce pcf8574 driver
Patch failed at 0001 hw: gpio: introduce pcf8574 driver
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: hw/gpio/Kconfig:16
error: hw/gpio/Kconfig: patch does not apply
error: patch failed: hw/gpio/meson.build:15
error: hw/gpio/meson.build: patch does not apply

Also please don't reply as v3, I almost missed v2, see
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch:
"Patches are easier to find if they start a new top-level thread, rather 
than being buried in-reply-to another existing thread."

Regards,

Phil.