Re: [PATCH v9 05/10] target/riscv: use vext_set_tail_elems_1s() in vcrypto insns

[Richard Henderson]

On 3/9/24 10:43, Daniel Henrique Barboza wrote:
> Vcrypto insns should also use the same helper the regular vector insns
> uses to update the tail elements.
>
> Move vext_set_tail_elems_1s() to vector_internals.c and make it public.
> Use it in vcrypto_helper.c to set tail elements instead of
> vext_set_elems_1s(). Helpers must set env->vstart = 0 after setting the
> tail.
>
> Signed-off-by: Daniel Henrique Barboza<dbarboza@ventanamicro.com>
> ---
>   target/riscv/vcrypto_helper.c   | 63 ++++++++++++---------------------
>   target/riscv/vector_helper.c    | 30 ----------------
>   target/riscv/vector_internals.c | 29 +++++++++++++++
>   target/riscv/vector_internals.h |  4 +++
>   4 files changed, 56 insertions(+), 70 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~