[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 6/7] migration/multifd: Enable multifd zero page checking by d
From: |
Hao Xiang |
Subject: |
[PATCH v5 6/7] migration/multifd: Enable multifd zero page checking by default. |
Date: |
Sat, 9 Mar 2024 07:57:27 +0000 |
From: Hao Xiang <hao.xiang@bytedance.com>
1. Set default "zero-page-detection" option to "multifd". Now
zero page checking can be done in the multifd threads and this
becomes the default configuration.
2. Handle migration QEMU9.0 -> QEMU8.2 compatibility. We provide
backward compatibility where zero page checking is done from the
migration main thread.
Signed-off-by: Hao Xiang <hao.xiang@bytedance.com>
---
hw/core/machine.c | 4 +++-
migration/options.c | 2 +-
qapi/migration.json | 6 +++---
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 9ac5d5389a..0e9d646b61 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -32,7 +32,9 @@
#include "hw/virtio/virtio-net.h"
#include "audio/audio.h"
-GlobalProperty hw_compat_8_2[] = {};
+GlobalProperty hw_compat_8_2[] = {
+ { "migration", "zero-page-detection", "legacy"},
+};
const size_t hw_compat_8_2_len = G_N_ELEMENTS(hw_compat_8_2);
GlobalProperty hw_compat_8_1[] = {
diff --git a/migration/options.c b/migration/options.c
index 8c849620dd..d61d31be24 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -181,7 +181,7 @@ Property migration_properties[] = {
MIG_MODE_NORMAL),
DEFINE_PROP_ZERO_PAGE_DETECTION("zero-page-detection", MigrationState,
parameters.zero_page_detection,
- ZERO_PAGE_DETECTION_LEGACY),
+ ZERO_PAGE_DETECTION_MULTIFD),
/* Migration capabilities */
DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE),
diff --git a/qapi/migration.json b/qapi/migration.json
index 2684e4e9ac..aa1b39bce1 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -909,7 +909,7 @@
# (Since 8.2)
#
# @zero-page-detection: Whether and how to detect zero pages.
-# See description in @ZeroPageDetection. Default is 'legacy'.
+# See description in @ZeroPageDetection. Default is 'multifd'.
# (since 9.0)
#
# Features:
@@ -1106,7 +1106,7 @@
# (Since 8.2)
#
# @zero-page-detection: Whether and how to detect zero pages.
-# See description in @ZeroPageDetection. Default is 'legacy'.
+# See description in @ZeroPageDetection. Default is 'multifd'.
# (since 9.0)
#
# Features:
@@ -1339,7 +1339,7 @@
# (Since 8.2)
#
# @zero-page-detection: Whether and how to detect zero pages.
-# See description in @ZeroPageDetection. Default is 'legacy'.
+# See description in @ZeroPageDetection. Default is 'multifd'.
# (since 9.0)
#
# Features:
--
2.30.2
- [PATCH v5 0/7] Introduce multifd zero page checking., Hao Xiang, 2024/03/09
- [PATCH v5 2/7] migration/multifd: Allow clearing of the file_bmap from multifd, Hao Xiang, 2024/03/09
- [PATCH v5 1/7] migration/multifd: Allow zero pages in file migration, Hao Xiang, 2024/03/09
- [PATCH v5 3/7] migration/multifd: Add new migration option zero-page-detection., Hao Xiang, 2024/03/09
- [PATCH v5 4/7] migration/multifd: Implement zero page transmission on the multifd thread., Hao Xiang, 2024/03/09
- [PATCH v5 5/7] migration/multifd: Implement ram_save_target_page_multifd to handle multifd version of MigrationOps::ram_save_target_page., Hao Xiang, 2024/03/09
- [PATCH v5 6/7] migration/multifd: Enable multifd zero page checking by default.,
Hao Xiang <=
- [PATCH v5 7/7] migration/multifd: Add new migration test cases for legacy zero page checking., Hao Xiang, 2024/03/09