[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/9] meson: Remove --warn-common ldflag
From: |
Paolo Bonzini |
Subject: |
[PULL 3/9] meson: Remove --warn-common ldflag |
Date: |
Fri, 8 Mar 2024 19:11:55 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
--warn-common ldflag causes warnings for multiple definitions of
___asan_globals_registered when enabling AddressSanitizer with clang.
The warning is somewhat obsolete so just remove it.
The common block is used to allow duplicate definitions of uninitialized
global variables. In the past, GCC and clang used to place such
variables in a common block by default, which prevented programmers for
noticing accidental duplicate definitions. Commit 49237acdb725 ("Enable
ld flag --warn-common") added --warn-common ldflag so that ld warns in
such a case.
Today, both of GCC and clang don't use common blocks by default[1][2] so
any remaining use of common blocks should be intentional. Remove
--warn-common ldflag to suppress warnings for intentional use of
common blocks.
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85678
[2]: https://reviews.llvm.org/D75056
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-ID: <20240304-common-v1-1-1a2005d1f350@daynix.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
meson.build | 5 -----
1 file changed, 5 deletions(-)
diff --git a/meson.build b/meson.build
index c59ca496f2d..f9dbe7634e5 100644
--- a/meson.build
+++ b/meson.build
@@ -476,11 +476,6 @@ if host_os == 'windows'
qemu_ldflags += cc.get_supported_link_arguments('-Wl,--dynamicbase',
'-Wl,--high-entropy-va')
endif
-# Exclude --warn-common with TSan to suppress warnings from the TSan libraries.
-if host_os != 'sunos' and not get_option('tsan')
- qemu_ldflags += cc.get_supported_link_arguments('-Wl,--warn-common')
-endif
-
if get_option('fuzzing')
# Specify a filter to only instrument code that is directly related to
# virtual-devices.
--
2.43.2
- [PULL v2 0/9] Misc fixes and coverity CI for 2024-03-08, Paolo Bonzini, 2024/03/08
- [PULL 1/9] hw/scsi/lsi53c895a: add timer to scripts processing, Paolo Bonzini, 2024/03/08
- [PULL 2/9] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add(), Paolo Bonzini, 2024/03/08
- [PULL 4/9] hw/scsi/lsi53c895a: stop script on phase mismatch, Paolo Bonzini, 2024/03/08
- [PULL 5/9] hw/intc/apic: fix memory leak, Paolo Bonzini, 2024/03/08
- [PULL 3/9] meson: Remove --warn-common ldflag,
Paolo Bonzini <=
- [PULL 7/9] mips: do not list individual devices from configs/, Paolo Bonzini, 2024/03/08
- [PULL 8/9] run-coverity-scan: add --check-upload-only option, Paolo Bonzini, 2024/03/08
- [PULL 9/9] gitlab-ci: add manual job to run Coverity, Paolo Bonzini, 2024/03/08
- [PULL 6/9] oslib-posix: fix memory leak in touch_all_pages, Paolo Bonzini, 2024/03/08
- Re: [PULL v2 0/9] Misc fixes and coverity CI for 2024-03-08, Peter Maydell, 2024/03/09