Re: [PATCH 03/16] block: Fix missing ERRP_GUARD() for error_prepend()

[Zhao Liu]

On Thu, Feb 29, 2024 at 01:51:16PM -0600, Eric Blake wrote:
> Date: Thu, 29 Feb 2024 13:51:16 -0600
> From: Eric Blake <eblake@redhat.com>
> Subject: Re: [PATCH 03/16] block: Fix missing ERRP_GUARD() for
>  error_prepend()
> 
> On Thu, Feb 29, 2024 at 12:37:10AM +0800, Zhao Liu wrote:
> > From: Zhao Liu <zhao1.liu@intel.com>
> > 
> > As the comment in qapi/error, passing @errp to error_prepend() requires
> > ERRP_GUARD():
> > 
> 
> > 
> > In block.c, there're 4 functions passing @errp to error_prepend()
> > without ERRP_GUARD():
> >  - bdrv_co_create_opts_simple()
> >  - parse_json_filename()
> >  - bdrv_open_backing_file()
> >  - bdrv_append_temp_snapshot()
> > 
> > bdrv_co_create_opts_simple(), as an implementation of
> > BolckDriver.bdrv_co_create_opts(), its @errp parameter is so widely
> 
> BlockDriver
>

Good catch! Thanks and will fix!

Regards,
Zhao