Re: [PATCH v2 4/5] gdbstub: Add Xfer:siginfo:read stub

[Richard Henderson]

On 3/7/24 08:26, Gustavo Romero wrote:
> +void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx)
> +{
> +    unsigned long offset, len;
> +    uint8_t *siginfo_offset;
> +
> +    offset = get_param(params, 0)->val_ul;
> +    len = get_param(params, 1)->val_ul;
> +
> +    if (offset + len > sizeof(target_siginfo_t)) {

If you save the siginfo_len from gdb_handlesig, you can place this in user.c.

Is it really correct to reject (offset == 0) + (len == large), rather than 
truncate len?

> +    /* Reply */
> +    g_string_assign(gdbserver_state.str_buf, "l");
> +    gdb_memtox(gdbserver_state.str_buf, (const char *)siginfo_offset, len);

It seems easy enough to reply with the exact length remaining...


r~