Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

[Richard Henderson]

On 3/7/24 09:21, Alex Bennée wrote:
> > +    /*
> > +     * Writes out siginfo values byteswapped, accordingly to the target. It 
> > also
> > +     * cleans the si_type from si_code making it correct for the target.
> > +     */
> > +    tswap_siginfo(&k->info, &k->info);
> > +
>
> I'm not sure I like this, you have the same pointer to both a const and
> non-const arg. Do we assert we come through this once per signal and
> don't risk double swapping the contents?

I suggested this as an intermediate step -- the function will work perfectly fine with 
dest == source.  Follow-up patches should clean this up further, but I told Gustavo to not 
get distracted from his goal with *too* much cleanup.


r~