|
From: | David Hildenbrand |
Subject: | Re: [PATCH v2 1/4] physmem: Rename addr1 to more informative mr_addr in flatview_read/write() and similar |
Date: | Thu, 7 Mar 2024 17:23:08 +0100 |
User-agent: | Mozilla Thunderbird |
On 07.03.24 16:37, Jonathan Cameron wrote:
The calls to flatview_read/write[_continue]() have parameters addr and addr1 but the names give no indication of what they are addresses of. Rename addr1 to mr_addr to reflect that it is the translated address offset within the MemoryRegion returned by flatview_translate(). Similarly rename the parameter in address_space_read/write_cached_slow() Suggested-by: Peter Xu <peterx@redhat.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Much cleaner indeed! Reviewed-by: David Hildenbrand <david@redhat.com> -- Cheers, David / dhildenb
[Prev in Thread] | Current Thread | [Next in Thread] |