Re: [PATCH v2 2/6] qdev-monitor: fix error message in find_device_state()

[Markus Armbruster]

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> This "hotpluggable" here is misleading. Actually we check is object a
> device or not. Let's drop the word.
>
> SUggested-by: Markus Armbruster <armbru@redhat.com>

"Suggested"

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  system/qdev-monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
> index a13db763e5..9febb743f1 100644
> --- a/system/qdev-monitor.c
> +++ b/system/qdev-monitor.c
> @@ -890,7 +890,7 @@ static DeviceState *find_device_state(const char *id, 
> Error **errp)
>  
>      dev = (DeviceState *)object_dynamic_cast(obj, TYPE_DEVICE);
>      if (!dev) {
> -        error_setg(errp, "%s is not a hotpluggable device", id);
> +        error_setg(errp, "%s is not a device", id);
>          return NULL;
>      }

Perhaps including what @id resolved to could be useful, but that's
out of scope for this patch.

Reviewed-by: Markus Armbruster <armbru@redhat.com>