Re: [PATCH 07/14] tests/unit/test-smp-parse: Bump max_cpus to 4096

[Zhao Liu]

Hi Thomas,

> >           /*
> > -         * config: -smp 512
> > +         * config: -smp 4096
> >            * The test machine should tweak the supported max CPUs to
> > -         * 511 (MAX_CPUS - 1) for testing.
> > +         * 4095 (MAX_CPUS - 1) for testing.
> >            */
> > -        .config = SMP_CONFIG_GENERIC(T, MAX_CPUS, F, 0, F, 0, F, 0, F, 0),
> > -        .expect_error = "Invalid SMP CPUs 512. The max CPUs supported "
> > -                        "by machine '" SMP_MACHINE_NAME "' is 511",
> > +        .config = SMP_CONFIG_GENERIC(T, 4096, F, 0, F, 0, F, 0, F, 0),
> > +        .expect_error = "Invalid SMP CPUs 4096. The max CPUs supported "
> 
> You could maybe use stringify(MAX_CPUS) in above line
> (but it won't work for the 4095 below, so it's maybe not worth the effort)

Yes, it's also because of corner cases like 4095 that I don't do such a
thorough cleanup here.
 
> > +                        "by machine '" SMP_MACHINE_NAME "' is 4095",
> >       },
> >   };
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

Thanks!

Zhao