[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 0/9] VIRTIO-IOMMU: Introduce aw-bits and granule options
From: |
Eric Auger |
Subject: |
[PATCH v7 0/9] VIRTIO-IOMMU: Introduce aw-bits and granule options |
Date: |
Wed, 6 Mar 2024 21:32:39 +0100 |
This is a respin of
[1] [PATCH v5 0/4] VIRTIO-IOMMU: Introduce an aw-bits option
(https://lore.kernel.org/all/20240215084315.863897-1-eric.auger@redhat.com/)
which now also integrates
[PATCH v6 0/3] VIRTIO-IOMMU: Set default granule to host page size
(https://lore.kernel.org/all/20240227165730.14099-1-eric.auger@redhat.com/)
The introduction of those 2 new options and their new default values
fix bugs when assigning VFIO devices protected by a virtio-iommu.
patches 1 - 4: intro of the granule property, collected reviews
- we used to set the default granule to 4k. This causes failures
when hotplugging a VFIO device on a 64kB/64kB host/guest config:
"vfio: DMA mapping failed, unable to continue". When the device
is hotplugged the granule is already frozen to 4k wheras 64k is
needed. This series introduces a new granule option which is set
by default to the host page size.
patches 5 - 9: intro of the aw-bits property, needs further review
- we used to set the input address width to 64b. This causes
failures with some assigned devices where the guest driver
tries to use the full 64b input range whereas the physical IOMMU
supports less bits (39/48 gaw for instance on VTD). New default
usually match the host HW capability.
For more details please see the cover letter of [1] and [2].
This series can be found at:
https://github.com/eauger/qemu/tree/granule_aw_bits_v7
History:
v6 -> v7:
- Made property static in virt and pc_q35. Fix qtest 32 limit.
Eric Auger (9):
qdev: Add a granule_mode property
virtio-iommu: Add a granule property
virtio-iommu: Change the default granule to the host page size
qemu-options.hx: Document the virtio-iommu-pci granule option
virtio-iommu: Trace domain range limits as unsigned int
virtio-iommu: Add an option to define the input range width
hw/i386/q35: Set virtio-iommu aw-bits default value to 39
hw/arm/virt: Set virtio-iommu aw-bits default value to 48
qemu-options.hx: Document the virtio-iommu-pci aw-bits option
qapi/virtio.json | 18 +++++++++++++++
include/hw/qdev-properties-system.h | 3 +++
include/hw/virtio/virtio-iommu.h | 3 +++
hw/arm/virt.c | 17 ++++++++++++++
hw/core/machine.c | 6 ++++-
hw/core/qdev-properties-system.c | 14 ++++++++++++
hw/i386/pc_q35.c | 9 ++++++++
hw/virtio/virtio-iommu.c | 35 +++++++++++++++++++++++++----
tests/qtest/virtio-iommu-test.c | 2 +-
hw/virtio/trace-events | 2 +-
qemu-options.hx | 11 +++++++++
11 files changed, 113 insertions(+), 7 deletions(-)
--
2.41.0
- [PATCH v7 0/9] VIRTIO-IOMMU: Introduce aw-bits and granule options,
Eric Auger <=
[PATCH v7 6/9] virtio-iommu: Add an option to define the input range width, Eric Auger, 2024/03/06